This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Improve CMake handling of sse2 and sse3 and fix compile error #14757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix apache#14304 where CFLAGS were overriden instead of appended to.
larroy
changed the title
Improve CMake handling of sse2 and sse3
Improve CMake handling of sse2 and sse3 and fix compile error
Apr 22, 2019
@mxnet-label-bot add [CMake, build, Bug] |
@mxnet-label-bot add [pr-awaiting-review] |
@iblis17 any ideas? |
iblislin
added a commit
that referenced
this pull request
Apr 23, 2019
iblislin
added a commit
that referenced
this pull request
Apr 23, 2019
I rewrite that flaky test case: #14776 |
@lebeg please help review. |
lanking520
pushed a commit
that referenced
this pull request
Apr 24, 2019
stsukrov
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It would be better to have a separate module for SSE in general, but it looks good now as well |
lebeg
approved these changes
Apr 25, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
Fix apache#14304 where CFLAGS were overriden instead of appended to.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Bug
Build
CMake
CMake related bugs/issues/improvements
pr-awaiting-review
PR is waiting for code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a problem when compiling when F16C is enabled but the flag is missing for the compiler.
Fix #14304 where CFLAGS were overriden instead of appended to.
Improve CMake handling of sse2 and sse3
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.