Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Improve CMake handling of sse2 and sse3 and fix compile error #14757

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Apr 22, 2019

Description

This fixes a problem when compiling when F16C is enabled but the flag is missing for the compiler.
Fix #14304 where CFLAGS were overriden instead of appended to.
Improve CMake handling of sse2 and sse3

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Fix apache#14304 where CFLAGS were overriden instead of appended to.
@larroy larroy requested a review from szha as a code owner April 22, 2019 05:23
@larroy larroy changed the title Improve CMake handling of sse2 and sse3 Improve CMake handling of sse2 and sse3 and fix compile error Apr 22, 2019
@larroy
Copy link
Contributor Author

larroy commented Apr 22, 2019

@mxnet-label-bot add [CMake, build, Bug]

@marcoabreu marcoabreu added Bug Build CMake CMake related bugs/issues/improvements labels Apr 22, 2019
@larroy
Copy link
Contributor Author

larroy commented Apr 22, 2019

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Apr 22, 2019
@larroy
Copy link
Contributor Author

larroy commented Apr 22, 2019

@iblis17 any ideas?

@iblislin
Copy link
Member

I rewrite that flaky test case: #14776

@larroy
Copy link
Contributor Author

larroy commented Apr 23, 2019

@lebeg please help review.

lanking520 pushed a commit that referenced this pull request Apr 24, 2019
Copy link

@stsukrov stsukrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lebeg
Copy link
Contributor

lebeg commented Apr 25, 2019

It would be better to have a separate module for SSE in general, but it looks good now as well

@apeforest apeforest merged commit 97e09f2 into apache:master Apr 25, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Fix apache#14304 where CFLAGS were overriden instead of appended to.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Build CMake CMake related bugs/issues/improvements pr-awaiting-review PR is waiting for code review
Projects
None yet
6 participants